weiqingy commented on a change in pull request #1106: Making Samza-Sql-Shell commands pluggable URL: https://github.com/apache/samza/pull/1106#discussion_r304731587
########## File path: samza-sql-shell/conf/shell-defaults.conf ########## @@ -22,6 +22,8 @@ # Example: shell.executor = org.apache.samza.sql.client.impl.SamzaExecutor samza.sql.output = compact +# shell.commandhandler = com.linkedin.CustomeCommandHandler1 +# shell.commandhandler = com.linkedin.CustomeCommandHandler2 Review comment: We may prefer a value list to multiple commandhandler entries, as multiple entries could pervade the configuration file and become hard to notice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
