abhishekshivanna commented on a change in pull request #988: SAMZA-2160 -
Ability to configure application type on YARN deploys
URL: https://github.com/apache/samza/pull/988#discussion_r305000175
##########
File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java
##########
@@ -219,6 +227,10 @@ public String getYarnApplicationModifyAcl() {
return get(YARN_APPLICATION_MODIFY_ACL, null);
}
+ public String getYarnApplicationType() {
Review comment:
@prateekm this config is not to be used by the core framework to use in
order to distinguish between the types.
Its is meant to have the `Application Type` be populated as part of YARN's
APIs, which makes this type queryable for tools that need this information.
I still think this should be `yarn.application.type` and not
`samza.internal.app.type` because its not meant to be used by the Samza
framework.
@shanthoosh hopefully the above comment addresses your question as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
