weiqingy commented on issue #1106: Making Samza-Sql-Shell commands pluggable URL: https://github.com/apache/samza/pull/1106#issuecomment-513416791 Issues we have left untouched but maybe as a future work: The environment variables (operated by the `SET` command). Shall a `commandhandler` have its own environment variables? Shall their environment variables start with `shell.`? At the moment we treat all environment variables starting with `shell.` as the Shell's, and pass everything else to the executor. The logic may no longer work. We may need to distinguish them, like `shell.` , `executor.`, `commandhandler1.`, `commandhandler2.`, etc. The SET command and multiple `commandhandler`s. Just like we allow user to change the `executor` via the `SET` command, we allow user to change `commandhandler`s via the `SET` command. However, with multiple `commandhandler`s allowed, it's a bit tricky. Say a user has loaded `commandhandler1` and `commandhandler2`. He or she now wants to use `commandhandler3` as well. We wouldn't want them to issue a command like: `SET commandhandler = commandhandler1, commandhandler2, commandhandler3` What's in my mind is new commands `load` and `unload`. User may issue commands like: ``` load commandhandler1 load commandhandler2 ``` We may also want to consider distinguish commands of different commandhandlers by adding a prefix on the command, like: ``` commandhandler1.commandA commandhandler2.commandA ``` Let me know what you think.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
