atoomula commented on issue #1106: Making Samza-Sql-Shell commands pluggable URL: https://github.com/apache/samza/pull/1106#issuecomment-513487659 > my 2-mites: > > * the load/unload commands makes perfect sense, can be a future work > * I am not a big fan of prefixing commands with handlers, not very user friendly? ... besides, with load/unload this won't be needed, but I don't anticipate users shuffling command handlers much, this feature is mainly to allow each user to plug-in their favorite handler. > * We can discuss offline the env vars scope, I don't see them applicable per handler... I think we need to differentiate between what environment variables users can load/set dynamically and what can be loaded at shell startup time. Command handler is one which sits in a bucket where it can be loaded only at shell startup time. It makes code also much simpler. I'm thinking about prefixing/name-spacing such variables so that it is easier to identify such env vars. It need not go as part of this PR but what do you guys think ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
