rmatharu commented on a change in pull request #1108: SAMZA-2277: Semantics for
cluster-manager.container.retry.window.ms not reflected in code
URL: https://github.com/apache/samza/pull/1108#discussion_r305990813
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -104,25 +105,26 @@
*/
private final ClusterResourceManager clusterResourceManager;
- /**
- * If there are too many failed container failures (configured by
job.container.retry.count) for a
- * processor, the job exits.
- */
- private volatile boolean tooManyFailedContainers = false;
-
/**
* Exception thrown in callbacks, such as {@code containerAllocator}
*/
private volatile Throwable exceptionOccurred = null;
+ private ContainerProcessManagerMetrics containerProcessManagerMetrics;
+ private JvmMetrics jvmMetrics;
+ private Map<String, MetricsReporter> metricsReporters;
+
/**
* A map that keeps track of how many times each processor failed. The key
is the processor ID, and the
* value is the {@link ProcessorFailure} object that has a count of failures.
*/
- private final Map<String, ProcessorFailure> processorFailures = new
HashMap<>();
- private ContainerProcessManagerMetrics containerProcessManagerMetrics;
- private JvmMetrics jvmMetrics;
- private Map<String, MetricsReporter> metricsReporters;
+ final Map<String, ProcessorFailure> processorFailures = new HashMap<>();
+
+ /**
+ * If there are too many failed container failures (configured by
job.container.retry.count) for a
+ * processor, the job exits.
+ */
+ volatile boolean tooManyFailedContainers = false;
Review comment:
Would it be better to expose a getter instead, for unit-testing than make
package private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
