[
https://issues.apache.org/jira/browse/SAMZA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890455#comment-16890455
]
Weiqing Yang commented on SAMZA-1960:
-------------------------------------
The issue 2 has been resolved.
> Refactor QueryTranslator unit tests
> -----------------------------------
>
> Key: SAMZA-1960
> URL: https://issues.apache.org/jira/browse/SAMZA-1960
> Project: Samza
> Issue Type: Bug
> Components: sql
> Reporter: Weiqing Yang
> Priority: Major
> Fix For: 0.15.0
>
>
> This Jira is to track the follow issues:
> # Currently, the unit tests about "QueryTranslator" are using their own
> version of
> [translate|https://github.com/apache/samza/blob/master/samza-sql/src/main/java/org/apache/samza/sql/translator/QueryTranslator.java#L107](),
> the logic of which is a little messy. We should either use the translate()
> [here|https://github.com/apache/samza/blob/master/samza-sql/src/main/java/org/apache/samza/sql/translator/QueryTranslator.java#L126]
> or refactor the test version of
> [translate|https://github.com/apache/samza/blob/master/samza-sql/src/main/java/org/apache/samza/sql/translator/QueryTranslator.java#L107]()
> and its related unit tests.
> # We should rename the package name of
> "[testutil|https://github.com/apache/samza/tree/master/samza-sql/src/main/java/org/apache/samza/sql/testutil]";
> to "util".
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
