[
https://issues.apache.org/jira/browse/SAMZA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890468#comment-16890468
]
Cameron Lee commented on SAMZA-1760:
------------------------------------
I haven't had a chance to finish the initial attempt at this, so I will mark
the assignee back to "Unassigned" for now.
The original PR (#564) might still have some useful ideas, but a lot has
changed since it went out.
> SystemAdmin is not started properly in a few places
> ---------------------------------------------------
>
> Key: SAMZA-1760
> URL: https://issues.apache.org/jira/browse/SAMZA-1760
> Project: Samza
> Issue Type: Bug
> Reporter: Cameron Lee
> Assignee: Cameron Lee
> Priority: Major
> Fix For: 0.14.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/samza/pull/397] added a "start" and "stop" to the
> SystemAdmin interface. Most places got updated to manage the lifecycle.
> However, a few places were missed (or other changes were made more recently
> that did not correctly manage the lifecycle):
> # CoordinatorStreamSystemConsumer starts a SystemAdmin in its "start"
> method. However, it uses SystemAdmin.getSystemStreamMetadata in "register",
> which is called before "start". This class properly stops SystemAdmin.
> # SystemConsumerBench does not start/stop the SystemAdmin.
> # TestRunner does not start/stop the SystemAdmin.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
