PawasChhokra commented on a change in pull request #1008: SAMZA-2174: Throw a
record too large exception for oversized records in changelog
URL: https://github.com/apache/samza/pull/1008#discussion_r306912750
##########
File path:
samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala
##########
@@ -32,15 +32,15 @@ import org.apache.samza.storage.{StorageEngine,
StorageEngineFactory, StorePrope
import org.apache.samza.system.SystemStreamPartition
import org.apache.samza.task.MessageCollector
import org.apache.samza.util.ScalaJavaUtil.JavaOptionals
-import org.apache.samza.util.{HighResolutionClock, ScalaJavaUtil}
+import org.apache.samza.util.{HighResolutionClock, Logging}
/**
* A key value storage engine factory implementation
*
* This trait encapsulates all the steps needed to create a key value storage
engine. It is meant to be extended
* by the specific key value store factory implementations which will in turn
override the getKVStore method.
*/
-trait BaseKeyValueStorageEngineFactory[K, V] extends StorageEngineFactory[K,
V] {
+trait BaseKeyValueStorageEngineFactory[K, V] extends StorageEngineFactory[K,
V] with Logging {
Review comment:
No. Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
