mynameborat commented on a change in pull request #1126: Adding two additional params to DiagnosticsStreamMessage URL: https://github.com/apache/samza/pull/1126#discussion_r310820902
########## File path: samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsManager.java ########## @@ -80,20 +82,20 @@ private final SystemStream diagnosticSystemStream; public DiagnosticsManager(String jobName, String jobId, Map<String, ContainerModel> containerModels, - Integer containerMemoryMb, Integer containerNumCores, Integer numStoresWithChangelog, String containerId, - String executionEnvContainerId, String taskClassVersion, String samzaVersion, String hostname, + Integer containerMemoryMb, Integer containerNumCores, Integer numStoresWithChangelog, Long maxHeapSizeBytes, Integer containerThreadPoolSize, Review comment: nit: can we add the new parameters at the end? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
