shanthoosh commented on a change in pull request #1127: SAMZA-2291: Custom IME
Put in InMemoryManager runs into Offset mismatch even if offsets are correctly
set
URL: https://github.com/apache/samza/pull/1127#discussion_r310857214
##########
File path:
samza-core/src/main/java/org/apache/samza/system/inmemory/InMemoryManager.java
##########
@@ -88,7 +88,7 @@ void put(SystemStreamPartition ssp, Object key, Object
message) {
void put(SystemStreamPartition ssp, IncomingMessageEnvelope envelope) {
List<IncomingMessageEnvelope> messages = bufferedMessages.get(ssp);
String offset = String.valueOf(messages.size());
- if (envelope.getOffset().equals(offset)) {
+ if (!envelope.getOffset().equals(offset)) {
Review comment:
Would be great if we can check if the envelope.getOffset() is not null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
