dnishimura commented on a change in pull request #1132: SAMZA-2296: Metadata 
streams not created in Standalone
URL: https://github.com/apache/samza/pull/1132#discussion_r312523305
 
 

 ##########
 File path: 
samza-core/src/main/java/org/apache/samza/standalone/PassthroughJobCoordinator.java
 ##########
 @@ -86,7 +86,7 @@ public void start() {
     try {
       jobModel = getJobModel();
       // TODO metrics registry has been null here for a while; is it safe?
-      MetadataResourceUtil metadataResourceUtil = new 
MetadataResourceUtil(jobModel, null, getClass().getClassLoader());
+      MetadataResourceUtil metadataResourceUtil = new 
MetadataResourceUtil(jobModel, null, getClass().getClassLoader(), config);
       metadataResourceUtil.createResources();
 
 Review comment:
   This is for checkpoint and changelog, not coordinator. The coordinator issue 
is a separate issue that does not affect version 1.2 and will be addressed in a 
separate PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to