atoomula commented on a change in pull request #1149: SAMZA-2316: Validate that
all non-default value fields in output schema are set in the projected fields.
URL: https://github.com/apache/samza/pull/1149#discussion_r321077610
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/avro/AvroTypeFactoryImpl.java
##########
@@ -60,62 +59,68 @@ private SqlSchema convertSchema(List<Schema.Field> fields)
{
SqlSchemaBuilder schemaBuilder = SqlSchemaBuilder.builder();
for (Schema.Field field : fields) {
- SqlFieldSchema fieldSchema = convertField(field.schema());
+ // Consider any field with default value as nullable. Is it the right
assumption ?
Review comment:
Thanks for clarifying the behavior. Updated the logic by separating out
nullable fields and fields with default values. Using default values for
validation but not nullable fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
