cameronlee314 commented on a change in pull request #1151: [SAMZA-2198] Fix
deadlock in container signal handler
URL: https://github.com/apache/samza/pull/1151#discussion_r324298237
##########
File path:
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
##########
@@ -976,41 +974,6 @@ class SamzaContainer(
}
}
- def addShutdownHook {
- val runLoopThread = Thread.currentThread()
- shutdownHookThread = new Thread("Samza Container Shutdown Hook Thread") {
- override def run() = {
- info("Shutting down, will wait up to %s ms." format shutdownMs)
- shutdownRunLoop() //TODO: Pull out shutdown hook to
LocalContainerRunner or SP
Review comment:
It's great to see TODOs resolved :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
