dnishimura commented on a change in pull request #1155: SAMZA-2322: Integrate 
startpoints with ZK Standalone integration tests.
URL: https://github.com/apache/samza/pull/1155#discussion_r324759859
 
 

 ##########
 File path: 
samza-test/src/test/java/org/apache/samza/test/processor/TestStreamApplication.java
 ##########
 @@ -141,7 +142,7 @@ public String toString() {
     }
 
     static TestKafkaEvent fromString(String message) {
-      String[] messageComponents = message.split("|");
+      String[] messageComponents = StringUtils.split(message, "|");
 
 Review comment:
   This was previously wrong. Calling `split` on the string directly expects a 
regex string and "|" is a regex character that needed to be escaped. Switched 
to `StringUtils.split` as it does what we thought was intended.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to