srinipunuru commented on a change in pull request #1153: SAMZA-2320: Samza-sql:
Refactor validation to cover more cases and make it more extensible.
URL: https://github.com/apache/samza/pull/1153#discussion_r324770260
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/avro/AvroTypeFactoryImpl.java
##########
@@ -67,11 +70,11 @@ private SqlSchema convertSchema(List<Schema.Field> fields)
{
return schemaBuilder.build();
}
- private SqlFieldSchema convertField(Schema fieldSchema) {
+ protected SqlFieldSchema convertField(Schema fieldSchema) {
Review comment:
Can you please add comments on why the classes that extend this needs
flexibility in this conversion behavior.Without comments the methods that are
being made protected seems arbitrary and it's hard to get clear picture on why
some methods are private and some are protected. If it is short term
workaround. Can we open a bug for long term fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
