abhishekshivanna commented on a change in pull request #1151: [SAMZA-2198] Fix deadlock in container signal handler URL: https://github.com/apache/samza/pull/1151#discussion_r325262553
########## File path: samza-core/src/test/java/org/apache/samza/runtime/TestClusterBasedProcessorLifecycleListener.java ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.runtime; + +import com.google.common.collect.ImmutableMap; +import org.apache.samza.SamzaException; +import org.apache.samza.config.MapConfig; +import org.apache.samza.config.TaskConfig; +import org.apache.samza.container.RunLoop; +import org.apache.samza.container.SamzaContainer; +import org.apache.samza.processor.StreamProcessorTestUtils; +import org.apache.samza.task.StreamTask; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mockito; + +import static org.mockito.Mockito.*; + + +public class TestClusterBasedProcessorLifecycleListener { + + private SamzaContainer container; + private RunLoop mockRunLoop; + private ClusterBasedProcessorLifecycleListener clusterBasedProcessorLifecycleListener; + private ProcessorLifecycleListener processorLifecycleListener; + private Runnable mockOnSignal; + + @Before + public void setup() { + mockRunLoop = mock(RunLoop.class); + mockOnSignal = mock(Runnable.class); + container = StreamProcessorTestUtils.getDummyContainer(mockRunLoop, Mockito.mock(StreamTask.class)); Review comment: Good point! Seems like the tests for `SamzaContainer` does this check already. Fixed my tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
