cameronlee314 commented on a change in pull request #1159: Fix
ClusterBasedProcessorLifecycleListener test to exit without waiting for timeout
URL: https://github.com/apache/samza/pull/1159#discussion_r325349767
##########
File path:
samza-core/src/test/java/org/apache/samza/runtime/TestClusterBasedProcessorLifecycleListener.java
##########
@@ -79,11 +79,14 @@ public void testLifecycleListenerAfterFailure() {
public void testShutdownHookInvokesShutdownHookCallback() {
doNothing().when(mockShutdownHookCallback).run();
- // setup shutdown hook
+ // call beforeStart to setup shutdownHook
Review comment:
I think the timeout is actually set to 1ms in the setup, so this still might
trigger the timeout. Could you set the timeout to something bigger? Then at
least some could manually see the log to verify that the timeout did not get
hit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
