cameronlee314 commented on a change in pull request #1157: SAMZA-2325 : Adding
logic to read system config for repl-factor when creating a topic
URL: https://github.com/apache/samza/pull/1157#discussion_r325385652
##########
File path:
samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaConfig.scala
##########
@@ -220,7 +220,6 @@ class TestKafkaConfig {
val kafkaConfig = new KafkaConfig(mapConfig)
assertEquals("3",
kafkaConfig.getChangelogStreamReplicationFactor("store-with-override"))
assertEquals("2",
kafkaConfig.getChangelogStreamReplicationFactor("store-without-override"))
- assertEquals("2", kafkaConfig.getDefaultChangelogStreamReplicationFactor)
Review comment:
Can you please add unit tests for the new flows in `KafkaConfig` for RF?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
