rmatharu commented on a change in pull request #1157: SAMZA-2325 : Adding logic
to read system config for repl-factor when creating a topic
URL: https://github.com/apache/samza/pull/1157#discussion_r325393797
##########
File path:
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java
##########
@@ -546,6 +546,19 @@ public KafkaStreamSpec toKafkaSpec(StreamSpec spec) {
kafkaSpec = kafkaSpec.copyWithProperties(properties);
} else {
kafkaSpec = KafkaStreamSpec.fromSpec(spec);
+
Review comment:
yes, and for changelog not all configs were being respected (see
getChangelogStreamReplicationFactor)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
