rmatharu commented on a change in pull request #1156: SAMZA-2323: Provide 
option allow single containers to fail without failing the job
URL: https://github.com/apache/samza/pull/1156#discussion_r325898257
 
 

 ##########
 File path: 
samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java
 ##########
 @@ -192,6 +198,11 @@ else if (containsKey(CONTAINER_RETRY_COUNT)) {
     }
   }
 
+  public boolean getContainerFailJobAfterRetries() {
 
 Review comment:
   Should we add a javadoc here, 
   and call it something like 
   shouldFailJobAfterContainerRetries() ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to