bharathkumarasubramanian commented on a change in pull request #1160:
Transactional State [1/5]: Added Store Checkpoint API
URL: https://github.com/apache/samza/pull/1160#discussion_r326725558
##########
File path:
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
##########
@@ -236,6 +239,13 @@ class RocksDbKeyValueStore(
trace("Flushed store: %s" format storeName)
}
+ override def checkpoint(id: String): Optional[Path] = {
+ val checkpoint = Checkpoint.create(db)
+ val checkpointPath = dir.getPath + "-" + id
Review comment:
What happens if the path already exists? Do snapshots get overwritten or
does it create unique checkpoint file name every time checkpoint is created?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
