xinyuiscool commented on a change in pull request #1165: SAMZA-2326 : Add
interface to support specific configs
URL: https://github.com/apache/samza/pull/1165#discussion_r327320921
##########
File path:
samza-core/src/main/scala/org/apache/samza/util/CoordinatorStreamUtil.scala
##########
@@ -33,24 +32,21 @@ import org.apache.samza.system.{StreamSpec, SystemAdmin,
SystemFactory, SystemSt
import org.apache.samza.util.ScalaJavaUtil.JavaOptionals
import scala.collection.JavaConverters._
-import scala.collection.immutable.Map
object CoordinatorStreamUtil extends Logging {
+ val COORDINATOR_STREAM_FACTORY = "coordinatorstreamFactory"
Review comment:
The config needs to be comply with our existing naming conventions, which is
separated using dot, e.g. job.container.count. So I would suggest something
like job.coordinatorstream.config.factory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
