sborya commented on a change in pull request #1166: SAMZA-2328: [Scala cleanup]
Convert StreamConfig to Java (part 1: update test coverage and clarify
functionality in javadocs)
URL: https://github.com/apache/samza/pull/1166#discussion_r328260576
##########
File path: samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala
##########
@@ -199,16 +199,29 @@ class StreamConfig(config: Config) extends
ScalaMapConfig(config) with Logging {
}
/**
- * Gets the specified Samza property for a SystemStream. A Samza property
is a property that controls how Samza
- * interacts with the stream, as opposed to a property of the stream itself.
- *
- * Note, because the translation is not perfect between SystemStream and
streamId,
- * this method is not identical to getProperty(streamId, property)
- *
- * @param systemStream the SystemStream for which the property value will
be retrieved.
- * @param property the samza property name excluding the leading delimiter.
e.g. "samza.x.y"
- */
- protected def getSamzaProperty(systemStream: SystemStream, property:
String): String = {
+ * Gets the specified Samza property for a SystemStream. A Samza property is
a property that controls how Samza
Review comment:
Can we have an introductory passage that explains all the terms and the
differences:
StreamId vs StreamName vs PhysicalStreamName
'Samza.' prefixed properties - what do they mean
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
