mynameborat commented on a change in pull request #1163: Transactional State [4/5]: Added new interfaces for TaskRestoreManager and TaskStorageManager URL: https://github.com/apache/samza/pull/1163#discussion_r328790882
########## File path: samza-core/src/main/java/org/apache/samza/storage/TaskRestoreManager.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.storage; + +import java.util.Map; +import org.apache.samza.system.SystemStreamPartition; + + +/** + * The helper interface restores task state. + */ +public interface TaskRestoreManager { + + /** + * Init state resources such as file directories. + */ + void init(Map<SystemStreamPartition, String> checkpointedChangelogSSPOffsets); + + /** + * Restore state from checkpoints, state snapshots and changelog. + */ + void restore(); + + /** + * Stop all persistent stores after restoring. + */ + void stopPersistentStores(); Review comment: Should this be stop and not embed the store that it handles to maintain consistency with init and restore? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
