atoomula commented on a change in pull request #1153: SAMZA-2320: Samza-sql:
Refactor validation to cover more cases and make it more extensible.
URL: https://github.com/apache/samza/pull/1153#discussion_r331223879
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/avro/AvroTypeFactoryImpl.java
##########
@@ -44,37 +45,47 @@ public AvroTypeFactoryImpl() {
}
public SqlSchema createType(Schema schema) {
+ validateTopLevelAvroType(schema);
+ return convertSchema(schema.getFields(), true);
+ }
+
+ /**
+ * Given a schema field, determine if it is an optional field. There could
be cases where a field (like audit header)
Review comment:
Sure, removed the reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
