Sanil15 commented on a change in pull request #1170: Samza-2330: Handle expired
resource request for Container allocator when host affinity is disabled
URL: https://github.com/apache/samza/pull/1170#discussion_r331218046
##########
File path:
samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerProcessManager.java
##########
@@ -71,7 +71,7 @@
put("cluster-manager.container.retry.count", "1");
put("cluster-manager.container.retry.window.ms", "1999999999");
put("cluster-manager.allocator.sleep.ms", "1");
- put("cluster-manager.container.request.timeout.ms", "2");
+ put("cluster-manager.container.request.timeout.ms", "100");
Review comment:
This config is only used (in the current class) ContainerAllocator with Host
Affinity disabled cases in the current class TestContainerProcessManager and
none of the tests waits for expired requests (I added a separate test to
TestContainerAllocatorWithoutHostAffinity). There is no timeout test for
expired requests in this class, tests involving allocator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
