abhishekshivanna commented on a change in pull request #1172: SAMZA-2332: [AM isolation] YarnJob should pass new command and additional environment variables for AM deployment URL: https://github.com/apache/samza/pull/1172#discussion_r332815424
########## File path: samza-core/src/main/java/org/apache/samza/config/JobConfig.java ########## @@ -128,6 +128,9 @@ public static final String COORDINATOR_STREAM_FACTORY = "job.coordinatorstream.config.factory"; public static final String DEFAULT_COORDINATOR_STREAM_CONFIG_FACTORY = "org.apache.samza.util.DefaultCoordinatorStreamConfigFactory"; + // enables application master isolation + public static final String SAMZA_APPLICATION_MASTER_ISOLATION_ENABLED = "samza.application.master.isolation.enabled"; Review comment: Maybe we should include the word `dependency` in the config name while referring to isolation ? Also do you think we should maybe rename this config to be more generic like `samza.cluster.based.job.coordinator.dependency.isolation.enabled` ? If not, maybe move it to `YarnConfig.java` since this is YARN specific ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
