srinipunuru commented on a change in pull request #1186: SAMZA-2347: Samza Sql
- Fix AvroTypeFactoryImpl to properly denote a field as optional and nullable.
URL: https://github.com/apache/samza/pull/1186#discussion_r334578168
##########
File path:
samza-sql/src/test/java/org/apache/samza/sql/avro/schemas/ComplexRecord.avsc
##########
@@ -31,13 +31,13 @@
{
"name": "bool_value",
"doc": "Boolean Value.",
- "type": ["null", "boolean"]
+ "type": "boolean",
+ "default": null
Review comment:
Interesting, So you can set the default to null when the field is not
nullable?
Have you seen usages like this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
