prateekm commented on a change in pull request #1187: Notifying BEM about
kafkaConsumerProxy failure to prevent BEM poll-blockin in case of proxy failures
URL: https://github.com/apache/samza/pull/1187#discussion_r334677660
##########
File path:
samza-api/src/main/java/org/apache/samza/util/BlockingEnvelopeMap.java
##########
@@ -144,6 +146,12 @@ private void
initializeInternalStateForSSP(SystemStreamPartition systemStreamPar
while (envelope == null && !isAtHead(systemStreamPartition)) {
metrics.incBlockingPoll(systemStreamPartition);
envelope = queue.poll(1000, TimeUnit.MILLISECONDS);
+
+ // Check for consumerFailure and throw exception
+ if (this.failureCause != null) {
Review comment:
Minor: Can move before the metrics increment and poll (first thing in the
loop).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
