prateekm commented on a change in pull request #1200: Adding config 
stores.init.clean to clean all store-dirs on init, regardless of contents
URL: https://github.com/apache/samza/pull/1200#discussion_r337775608
 
 

 ##########
 File path: 
samza-core/src/main/java/org/apache/samza/storage/NonTransactionalStateTaskRestoreManager.java
 ##########
 @@ -110,20 +110,21 @@
    */
   @Override
   public void init(Map<SystemStreamPartition, String> 
checkpointedChangelogSSPOffsets) {
-    cleanBaseDirsAndReadOffsetFiles();
+    cleanBaseDirsAndReadOffsetFiles(new 
StorageConfig(config).getCleanLoggedStoreDirsOnInit());
 
 Review comment:
   What about the other restore manager?
   
   Extract variables.
   
   Add tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to