mynameborat commented on a change in pull request #1200: SAMZA-2360 : Adding 
config stores.init.clean to clean all store-dirs on init, regardless of contents
URL: https://github.com/apache/samza/pull/1200#discussion_r338668392
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/config/StorageConfig.java
 ##########
 @@ -73,6 +73,8 @@
   static final String INMEMORY_KV_STORAGE_ENGINE_FACTORY =
       
"org.apache.samza.storage.kv.inmemory.InMemoryKeyValueStorageEngineFactory";
 
+  public static final String CLEAN_LOGGED_STOREDIRS_ON_START = STORE_PREFIX + 
"container.start.clean";
 
 Review comment:
   If you do plan to open it up, you can leave it as is.
   Otherwise, I noticed we also insert `internal` as part of the config name to 
call out its internal. e.g. `samza.internal.execution.plan`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to