prateekm commented on a change in pull request #1209: SAMZA-2324: Adding KV
store metrics for rocksdb
URL: https://github.com/apache/samza/pull/1209#discussion_r342874988
##########
File path:
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
##########
@@ -101,6 +102,8 @@ object RocksDbKeyValueStore extends Logging {
}
))
+ metrics.newGauge("rocksdb.size-on-disk", () =>
FileUtils.sizeOfDirectory(new File(dir.getAbsolutePath)))
Review comment:
For 1, we should debug and fix that behavior if metrics aren't being emitted
correctly. Would also be good to verify if total-sst-files-size includes files
retained due to checkpoints, should be simple to verify locally, I can help set
that up. I'd prefer to try these out before making this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
