bkonold commented on a change in pull request #1209: SAMZA-2324: Adding KV
store metrics for rocksdb
URL: https://github.com/apache/samza/pull/1209#discussion_r343276337
##########
File path:
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
##########
@@ -101,6 +102,8 @@ object RocksDbKeyValueStore extends Logging {
}
))
+ metrics.newGauge("rocksdb.size-on-disk", () =>
FileUtils.sizeOfDirectory(new File(dir.getAbsolutePath)))
Review comment:
Ya you're right. Let's remove that from this PR then and circle back to it -
I can't commit time immediately to debug and fix.
Created SAMZA-2374 to track.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
