mynameborat commented on a change in pull request #1213: [WIP] SAMZA-2305:
Stream processor should ensure previous container is stopped during a rebalance
URL: https://github.com/apache/samza/pull/1213#discussion_r344399713
##########
File path:
samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java
##########
@@ -346,9 +352,10 @@ public void stop() {
try {
LOGGER.info("Shutting down the container: {} of stream processor:
{}.", container, processorId);
boolean hasContainerShutdown = stopSamzaContainer();
+ // todo: use interruptSamzaContainer method instead to give one more
chance for container to shutdown
Review comment:
Few reasons
1. I didn't want to change existing behavior for the code path that isn't
affected by the bug.
2. Lack of shutting down timely could mean two things, one it didn't react
to shutdown signal or it is spending more than `task.shutdown.ms` on the
shutdown sequence. Interrupting it would require handling interrupts during
shutdown sequence as well and requires more testing.
let me get rid of the todo for now and create a follow up ticket to evaluate
if giving it one more chance has tangible benefits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
