abhishekshivanna commented on a change in pull request #1229: Adding internal
config to retain non-logged stores on container start
URL: https://github.com/apache/samza/pull/1229#discussion_r354464519
##########
File path: samza-core/src/main/java/org/apache/samza/config/StorageConfig.java
##########
@@ -74,9 +74,12 @@
static final String INMEMORY_KV_STORAGE_ENGINE_FACTORY =
"org.apache.samza.storage.kv.inmemory.InMemoryKeyValueStorageEngineFactory";
- // Internal config to clean storeDirs of a store on container start. This is
used to benchmark bootstrap performance.
+ // Internal config to clean storeDirs of a logged store on container start.
This is used to benchmark bootstrap performance.
static final String CLEAN_LOGGED_STOREDIRS_ON_START = STORE_PREFIX +
"%s.clean.on.container.start";
+ // Internal config to clean storeDirs of a logged store on container start.
This is used to benchmark bootstrap performance.
+ static final String RETAIN_NONLOGGED_STOREDIRS_ON_START = STORE_PREFIX +
"%s.retain.on.container.start";
Review comment:
should we name this config to reflect the non-logged only case ?
`%s.retain.nonlogged.on.container.start`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
