rmatharu commented on a change in pull request #1241: SAMZA-2424: AM should
cache and serve serialized Job Model to containers
URL: https://github.com/apache/samza/pull/1241#discussion_r362586519
##########
File path:
samza-core/src/main/scala/org/apache/samza/coordinator/server/JobServlet.scala
##########
@@ -22,19 +22,22 @@ package org.apache.samza.coordinator.server
import java.util.concurrent.atomic.AtomicReference
-import org.apache.samza.SamzaException
-import org.apache.samza.job.model.JobModel
-import org.apache.samza.util.Logging
+import javax.servlet.http.{HttpServlet, HttpServletRequest,
HttpServletResponse}
/**
- * A servlet that dumps the job model for a Samza job.
+ * Serves the JSON serialized job model for the job.
*/
-class JobServlet(jobModelRef: AtomicReference[JobModel]) extends ServletBase
with Logging {
- protected def getObjectToWrite() = {
+class JobServlet(jobModelRef: AtomicReference[Array[Byte]]) extends
HttpServlet {
+ override protected def doGet(request: HttpServletRequest, response:
HttpServletResponse) {
Review comment:
Should we update the
doGet implementation in ServletBase ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
