cameronlee314 commented on a change in pull request #1239: SAMZA-2421: Add SystemProducer for Azure Blob Storage URL: https://github.com/apache/samza/pull/1239#discussion_r363978306
########## File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/avro/AzureBlobAvroWriter.java ########## @@ -108,6 +108,8 @@ private final long maxRecordsPerBlob; private final boolean useRandomStringInBlobName; private final Object currentDataFileWriterLock = new Object(); + // when either maxRecordsPerBlob or maxBlobSize is exceeded then a new blob is created + // with the same blobURLPrefix and blobNumber is suffixed to the blobURL to differentiate between the blobs Review comment: I thought you used timestamp and a random string to differentiate between blobs. Do you still need `blobNumber`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
