kw2542 commented on a change in pull request #1238: SAMZA-2407: Add
job.config.loader.* configs in JobConfig & corresponding env variables in
ShellCommandConfig
URL: https://github.com/apache/samza/pull/1238#discussion_r364375758
##########
File path: samza-core/src/main/java/org/apache/samza/config/JobConfig.java
##########
@@ -348,4 +358,11 @@ public String getCoordinatorStreamFactory() {
return get(COORDINATOR_STREAM_FACTORY,
DEFAULT_COORDINATOR_STREAM_CONFIG_FACTORY);
}
+ /**
+ * Get config loader factory according to the configs
+ * @return full qualified name of {@link ConfigLoaderFactory}
+ */
+ public String getConfigLoaderFactory() {
+ return get(CONFIG_LOADER_FACTORY);
Review comment:
It will eventually be required but optional now before we fully deprecate
the old path where we read config from coordinator stream.
I will use Optional<String> for now, and will change to required with
ConfigException when we clean up the old flow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
