Sanil15 commented on a change in pull request #1219: SAMZA-2373: Container
Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r365467786
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerManager.java
##########
@@ -97,7 +152,10 @@ void handleContainerLaunch(SamzaResourceRequest request,
String preferredHost, S
*/
void handleContainerStop(String processorId, String containerId, String
preferredHost, int exitStatus,
Duration preferredHostRetryDelay, ContainerAllocator containerAllocator)
{
- if (standbyContainerManager.isPresent()) {
+ if (hasActiveContainerPlacementAction(processorId)) {
+ LOG.info("Setting the for container state with processorId {} to be
stopped because of existing container placement action", processorId);
+
getPlacementActionMetadata(processorId).get().setContainerStatus(ContainerPlacementMetadata.ContainerStatus.STOPPED);
Review comment:
The metadata for a previously completed action is not deleted until a new
action is accepted, new is only accepted when an existing action is complete,
so this should not fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
