bkonold commented on a change in pull request #1246: SAMZA-2409: Update YarnJob
to construct job submission env varible
URL: https://github.com/apache/samza/pull/1246#discussion_r366112070
##########
File path: samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala
##########
@@ -173,10 +173,16 @@ object YarnJob extends Logging {
@VisibleForTesting
private[yarn] def buildEnvironment(config: Config, yarnConfig: YarnConfig,
jobConfig: JobConfig): Map[String, String] = {
- val coordinatorSystemConfig =
CoordinatorStreamUtil.buildCoordinatorStreamConfig(config)
val envMapBuilder = Map.newBuilder[String, String]
- envMapBuilder += ShellCommandConfig.ENV_COORDINATOR_SYSTEM_CONFIG ->
-
Util.envVarEscape(SamzaObjectMapper.getObjectMapper.writeValueAsString(coordinatorSystemConfig))
+ if (jobConfig.getConfigLoaderFactory.isPresent) {
+ envMapBuilder += ShellCommandConfig.ENV_SUBMISSION_CONFIG ->
+
Util.envVarEscape(SamzaObjectMapper.getObjectMapper.writeValueAsString(config))
Review comment:
Sounds good. Thanks for clarifying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
