dnishimura commented on a change in pull request #1227: SAMZA-2404: [SEP-22] 
Container Placement Handler for dispatching container placement messages 
between metastore and JobCoordinator
URL: https://github.com/apache/samza/pull/1227#discussion_r366461875
 
 

 ##########
 File path: 
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
 ##########
 @@ -316,6 +345,19 @@ private void onShutDown() {
     }
   }
 
+  private void shutDownContainerPlacementHandlerAndUtils() {
+    // Shutdown container placement handler
+    containerPlacementHandler.stop();
+    try {
+      containerPlacementHandlerThread.join();
+      LOG.info("Stopped container placement handler thread");
+      containerPlacementUtil.stop();
+    } catch (InterruptedException ie) {
+      LOG.error("Container Placement handler thread join threw an interrupted 
exception", ie);
 
 Review comment:
   This error log assumes `containerPlacementUtil.stop()` will never throw an 
exception. Is that true?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to