shanthoosh opened a new pull request #1252: Create coordinator steam in samza with compact.policy set to compact instead of delete. URL: https://github.com/apache/samza/pull/1252 Symptom: Coordinator kafka topic of a samza job currently gets created with cleanup.policy set to 'delete' instead of 'compact' for certain cases. This potentially leads to losing all the metadata(JobModel/Config) stored in coordinator stream for some samza jobs. This behavior was observed for hundreds of samza jobs within LI and would affect any job using recent samza-1.2 or samza-1.3 release in OSS. Cause: The control-flow in KafkaSystemAdmin.createStream to build the coordinator stream spec swallows the essential kafka-topic configurations and passes along the empty configuration bag to the kafka-broker when creating the coordinator stream. This issue was introduced in [SAMZA-1868](https://issues.apache.org/jira/browse/SAMZA-1868). Changes: Fix the topic-creation control-flow for the coordinator topics and generate the correct topic-configurations. Tests: Added unit tests to validate that the expected topic configuration bag was generated for the coordinator stream topics. API Changes: None Upgrade Instructions: None Usage Instructions: None
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
