Sanil15 commented on a change in pull request #1227: SAMZA-2404: [SEP-22]
Container Placement Handler for dispatching container placement messages
between metastore and JobCoordinator
URL: https://github.com/apache/samza/pull/1227#discussion_r366556438
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
##########
@@ -264,9 +279,15 @@ public void run() {
partitionMonitor.ifPresent(StreamPartitionCountMonitor::start);
inputStreamRegexMonitor.ifPresent(StreamRegexMonitor::start);
+ // ContainerPlacementHandler thread has to start after the cpm is started
+ LOG.info("Starting the container placement handler thread");
+ containerPlacementUtil.start();
+ containerPlacementHandlerThread.start();
+
boolean isInterrupted = false;
- while (!containerProcessManager.shouldShutdown() &&
!checkAndThrowException() && !isInterrupted) {
+ while (!containerProcessManager.shouldShutdown() &&
!checkAndThrowException() && !isInterrupted
+ && checkContainerPlacementHandlerThreadIsAlive()) {
Review comment:
sure, will change it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
