kw2542 commented on a change in pull request #1248: SAMZA-2410: Update
ClusterBasedJobCoordinator config retrieval logic from loader.
URL: https://github.com/apache/samza/pull/1248#discussion_r368079318
##########
File path: samza-core/src/test/java/org/apache/samza/util/TestConfigUtil.java
##########
@@ -161,6 +162,31 @@ public void testApplyRewriterClassDoesNotExist() {
assertEquals(expectedConfig, ConfigUtil.applyRewriter(new
MapConfig(fullConfig), REWRITER_NAME));
}
+ @Test
+ public void testLoadConfigWithoutLoader() {
+ Map<String, String> config = new HashMap<>();
+ config.put(JobConfig.JOB_NAME, "new-test-job");
+
+ Config actual = ConfigUtil.loadConfig(new MapConfig(config));
+
+ assertEquals(config.size(), actual.size());
+ assertEquals("new-test-job", actual.get(JobConfig.JOB_NAME));
Review comment:
Update the unit test to check ConfigException instead as we disallow config
w/o loader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
