rmatharu commented on a change in pull request #1227: SAMZA-2404: [SEP-22] Container Placement Handler for dispatching container placement messages between metastore and JobCoordinator URL: https://github.com/apache/samza/pull/1227#discussion_r369248788
########## File path: samza-core/src/test/java/org/apache/samza/clustermanager/container/placement/TestContainerPlacementObjectMapper.java ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.clustermanager.container.placement; + +import java.io.IOException; +import java.time.Duration; +import java.util.Random; +import java.util.UUID; +import org.apache.samza.container.placement.ContainerPlacementMessage; +import org.apache.samza.container.placement.ContainerPlacementRequestMessage; +import org.apache.samza.container.placement.ContainerPlacementResponseMessage; +import org.codehaus.jackson.map.ObjectMapper; +import org.junit.Test; + +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.assertEquals; + +public class TestContainerPlacementObjectMapper { + + @Test + public void testIncomingContainerMessageSerDe() throws IOException { + testContainerPlacementRequestMessage( + new ContainerPlacementRequestMessage(UUID.randomUUID(), "app-attempt-001", "4", "ANY_HOST", System.currentTimeMillis())); + testContainerPlacementRequestMessage( + new ContainerPlacementRequestMessage(UUID.randomUUID(), "app-attempt-001", "4", "ANY_HOST", + Duration.ofSeconds(10), System.currentTimeMillis())); + } + + @Test + public void testOutgoingContainerMessageSerDe() throws IOException { + testContainerPlacementResponseMessage(new ContainerPlacementResponseMessage(UUID.randomUUID(), "app-attempt-001", + Integer.toString(new Random().nextInt(5)), "ANY_HOST", ContainerPlacementMessage.StatusCode.BAD_REQUEST, + "Request ignored redundant", System.currentTimeMillis())); + testContainerPlacementResponseMessage(new ContainerPlacementResponseMessage(UUID.randomUUID(), "app-attempt-001", + Integer.toString(new Random().nextInt(5)), "ANY_HOST", Duration.ofSeconds(10), + ContainerPlacementMessage.StatusCode.IN_PROGRESS, "Request is in progress", System.currentTimeMillis())); + } + + private void testContainerPlacementRequestMessage(ContainerPlacementRequestMessage requestMessage) + throws IOException { + ObjectMapper objectMapper = ContainerPlacementMessageObjectMapper.getObjectMapper(); + ContainerPlacementMessage message = + objectMapper.readValue(objectMapper.writeValueAsString(requestMessage), ContainerPlacementMessage.class); + assertTrue(message instanceof ContainerPlacementRequestMessage); + ContainerPlacementRequestMessage deserializedRequest = (ContainerPlacementRequestMessage) message; + assertEquals(requestMessage, deserializedRequest); + assertEquals(deserializedRequest.getStatusCode(), ContainerPlacementMessage.StatusCode.CREATED); Review comment: Since ContainerPlacementMessage.equals includes statusCode, this step is not needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
