bkonold opened a new pull request #1260: SAMZA-2446: Invoke onCheckpoint only for registered SSPs URL: https://github.com/apache/samza/pull/1260 Symptom: onCheckpoint will be invoked for changelog SSPs if job.changelog.system is configured to be the same as an input system which implements CheckpointListener. This can be problematic because the types of checkpoints being written for changelog SSPs and input SSPs are different. Cause: OffsetManager.writeCheckpoint is called with a Checkpoint parameter that includes changelog SSP checkpoints. Changes: OffsetManager will now only invoke onCheckpoint for SSPs that are registered with it. Tests: Wrote a test which attempts to write a Checkpoint with OffsetManager.writeCheckpoint which includes an SSP which was not registered with the OffsetManager. The test verifies that the callback is invoked only for those SSPs that were registered via OffsetManager.register. This test fails without the patch and passes with it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
