cameronlee314 commented on a change in pull request #1255: SAMZA-2429: Update
LocalApplicatoinRunner to load full job config from config loader when present.
URL: https://github.com/apache/samza/pull/1255#discussion_r372033238
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -150,6 +163,10 @@ static MetadataStoreFactory
getDefaultCoordinatorStreamStoreFactory(JobConfig jo
}
private static Optional<CoordinationUtils> getCoordinationUtils(Config
config) {
+ if (new JobConfig(config).getConfigLoaderFactory().isPresent()) {
+ config = ConfigUtil.loadConfig(config);
+ }
Review comment:
Same as above about multiple calls to `loadConfig`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
