mynameborat commented on a change in pull request #1263: SAMZA-2448: [Scala
cleanup] Clean up and convert some parts of samza-kafka to java
URL: https://github.com/apache/samza/pull/1263#discussion_r377860112
##########
File path:
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
##########
@@ -159,29 +159,31 @@ class TestKafkaCheckpointManager extends
KafkaServerTestHarness {
def testFailOnTopicValidation(): Unit = {
// By default, should fail if there is a topic validation error
val checkpointTopic = "eight-partition-topic";
- val kcm1 = createKafkaCheckpointManager(checkpointTopic)
- kcm1.register(taskName)
+ val kcm = createKafkaCheckpointManager(checkpointTopic)
Review comment:
Did you leave it out as is and plan to rewrite these tests when
KafkaCheckpointManager is rewritten in Java?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
