mynameborat commented on a change in pull request #1236: SAMZA-2419: removing
duplicate cleaning of stores
URL: https://github.com/apache/samza/pull/1236#discussion_r379087582
##########
File path:
samza-core/src/test/java/org/apache/samza/storage/TestTransactionalStateTaskRestoreManager.java
##########
@@ -208,13 +210,22 @@ public void testStoreDeletedWhenCleanDirsFlagSet() {
return Long.valueOf(offset1).compareTo(Long.valueOf(offset2));
});
+ File dummyCurrentDir = new File("currentDir");
+ File dummyCheckpointDir = new File("checkpointDir1");
+ when(mockStorageManagerUtil.getTaskStoreDir(mockLoggedStoreBaseDir,
store1Name, taskName, TaskMode.Active))
+ .thenReturn(dummyCurrentDir);
+
when(mockStorageManagerUtil.getTaskStoreCheckpointDirs(mockLoggedStoreBaseDir,
store1Name, taskName, TaskMode.Active))
+ .thenReturn(ImmutableList.of(dummyCheckpointDir));
+
StoreActions storeActions =
TransactionalStateTaskRestoreManager.getStoreActions(
mockTaskModel, mockStoreEngines, mockStoreChangelogs,
mockCheckpointedChangelogOffset,
mockCurrentChangelogOffsets, mockSystemAdmins, mockStorageManagerUtil,
mockLoggedStoreBaseDir, mockNonLoggedStoreBaseDir, mockConfig,
mockClock);
// ensure that there is one directory to delete
Review comment:
nit: update the comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
