rmatharu commented on a change in pull request #1281: SAMZA-2378: Container
Placements support for Standby containers enabled jobs
URL: https://github.com/apache/samza/pull/1281#discussion_r382831411
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/StandbyContainerManager.java
##########
@@ -425,6 +423,15 @@ public void handleExpiredResourceRequest(String
containerID, SamzaResourceReques
}
}
+ /**
+ * Fetches a list of standby container for an active container
+ * @param activeContainerId logical id of the container ex: 0,1,2
+ * @return list of standby containers ex: for active container 0: {0-0, 0-1}
+ */
+ List<String> getStandbyList(String activeContainerId) {
+ return this.standbyContainerConstraints.get(activeContainerId);
+ }
Review comment:
see comment above on simplifying,
You can additional methods here to simplify the caller's logic, so that the
caller does not need to know the internals of the standby container manager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
